Code Contributions to the software

[mawa]

o·pen-source

my final point is i could give a flying f* what you think.

you're an unkown person behind a computer trying to dictate how i spend my (not) free time and effort and energy. I didn't agree to anything when I decided to enhance the software. I chose to do it because i wanted to. what would make you think i would care what you thought?

Sorry thereza, If somebody uses f.. words in a forum he IMHO disqualifies himself.

As it seems you are not willing to work as a team.

OK I will take that and leave you do your work. Best would be that you publish your own version in a GitHub branch of your own if you get to be capable of using GitHub. Then anyone can pick what he thinks is valuable from your source and implement it if he likes and in the style he likes. It's open software you said!

But I wish that Juha merges only important modifications from you and other contributors in an upward compatible style.
I and probably many other Litplacer customers do not want to loose work by some nice but incompatible file format change. Therefore I already suggested versioning in an other thread .

I also wish that the published software is built on the parts- especially the cameras and the TinyG as is - that Juha supplied.

Why ? because I bought the Liteplacer to assemble my companies project prototypes and hopefully for small production volumes which are too expensive to be done by a commercial smd assembler.

BTW: Contrary to you - are you a girl Thereza or a boy the-Reza? - you can see who I am in my user info here in the forum.

[mrandt]

Hi,

I tried to check out and compile the verison Reza posted to SVN.

The latest commit (release 3) seems to be missing one or more files - namely

Code: Select all

Video\MyAsyncVideoSource.cs

Could you please add / commit that file?

I would like to take the extensions for a test ride

Thanks
Malte

[thereza]

Missed that file, will add it. thnx.

Also, I found an annoying bug. when you are placing parts and the Z distance is unknown, it will reverse the homing direction to determine the placement height. If you restart the code at this point, the code that resets the homing direction will fail because it first checks to see if the direction needs to change. On power-up, it believes that it is set correctly so it doesn't bother resetting it. Just killed a needle as it homed downward then moved the needle hard across various objects.

I'll check in the changes in a few minutes.

Thanks,
Reza

ps. to the hater - as I said, 80% of the code has changed including the UI so it'll be near impossible to back-port portions of the code into the original code base.

[thereza]

I've uploaded binaries and posted some instructions here : http://liteplacer.com/phpBB/viewtopic.p ... p=522#p522

[mrandt]

OK, thanks. I am at revision 5 from SVN now.

Another missing file:

Code: Select all

Could not find file 'LitePlacer\QuickAddForm.cs'

[thereza]

OK, thanks. I am at revision 5 from SVN now.

Another missing file:

Code: Select all

Could not find file 'LitePlacer\QuickAddForm.cs'

thanks - committed.

[mrandt]

Still files missing...

Code: Select all

Error	1	Resource file "QuickAddForm.resx" cannot be found.	LitePlacer

Could you please add and commit all the files and dependencies and maybe do a quick check out to another folder and see if project still compiles?

Highly appreciated, thanks in advance.

[mawa]

@thereza:

congratulations, your redesign of the UI is very good.

Just some small misalignments of some buttons and group box locations and sizes. I know you'll fix them.

And you added menu bar and a clear button to the serial monitor. Not to forget the CameraView form!

You could even make your code better by using more String.Formats for those + concatenated messages. Why ? It's easier to read and to eventually localize the application.

To assure easy localization and to prevent surprising errors after e.g. changing a buttons caption you should avoid using the displayed text of a button e.g. like in the MethodSelectionForm but put a lower or uppercase string text in the tag property of the button instead.

A similar surprise trap is using absolute .ColumnIndex values to differ columns and cells. I suggest using the columns unique DataPropertyName.

so instead of:

Code: Select all

if (JobData_GridView.CurrentCell.ColumnIndex == 3) {

use:

Code: Select all

if (JobData_GridView.CurrentCell.OwningColumn.DataPropertyName.Equals("Method")) {

Then the column order does not care and you can freely insert columns to the left of a given column.

And a final wish /suggestion: place all serialized .xml files (locations,Jobdata & tapeObjs) into a subdirectory. preferably in That makes it easier to move them into a release directory.

Looking forward to your next results.

[thereza]

thanks. feel free to fix them and submit diffs (the miss alignments). my goal is to get the code to a functional point for my own use while making it useful to others - so someone else is welcome to add localization code to it. I use a mix of + and string.format() depending based on complexity and legibility.

All the forms are now object backed and should be accessed via

(objectType) datagivdview.selectedcell.owningrow.databounditem (or something like that) so you can access the object's parameters directly. they will emit a change notification so updating the object will automatically update the table. haven't migrated all the code, and if the current code works then i'm leaving it alone.

I'm not a fan of methodselectionform. thinking of just making it a combobox instead in the job table.

my focus now is on component placement. the qfn (&bga) component placement is working most of the time but sometimes it doesn't. i think it's a bug in tinyg as the supplied angles are correct but it ends up off by a bit. I'll add sot-23 next.
finally, i'm gong to add code to visually determine which tape positions have components so you can also see components counts, etc.

just checked in the latest changes. big addition is being able to set the camera exposure. if i add some more external aforge classes (contributed) i should be able to control brightness as well. i'm finding the camera's auto-adjustments too variable.

another area that needs to be redone is the error handling and job abort / pause stuff.

i can't stress how major an improvement the pressure sensor has been in using the device. it really should be included in the kit moving forward.

reza

[mrandt]

Cool stuff, thanks Reza.

I just updated from SVN and could finally build from source now

Software does not run on my office computer yet - it has no cameras connected and code does not seem to error-handle that situation yet... I will figure that out tomorrow and test on my LitePlacer.